TMP / Fixed vulkan_frame.cpp

desktop/graphics/vulkan_frame.cpp

@@ -11,8 +11,8 @@
 namespace progressia::desktop {
 
 Frame::Frame(Vulkan &vulkan)
-    : vulkan(vulkan),
-      commandBuffer(vulkan.getCommandPool().allocateMultiUse()) {
+    : vulkan(vulkan), commandBuffer(vulkan.getCommandPool().allocateMultiUse()),
+      imageAvailableSemaphore(), renderFinishedSemaphore(), inFlightFence() {
 
     VkSemaphoreCreateInfo semaphoreInfo{};
     semaphoreInfo.sType = VK_STRUCTURE_TYPE_SEMAPHORE_CREATE_INFO;
@@ -97,12 +97,12 @@ bool Frame::startRender() {
                       vulkan.getPipeline().getVk());
 
     VkViewport viewport{};
-    viewport.x = 0.0f;
-    viewport.y = 0.0f;
+    viewport.x = 0.0F;
+    viewport.y = 0.0F;
     viewport.width = (float)extent.width;
     viewport.height = (float)extent.height;
-    viewport.minDepth = 0.0f;
-    viewport.maxDepth = 1.0f;
+    viewport.minDepth = 0.0F;
+    viewport.maxDepth = 1.0F;
     vkCmdSetViewport(commandBuffer, 0, 1, &viewport);
 
     VkRect2D scissor{};

tools/clang-tidy/clang-tidy.yml

@@ -10,6 +10,7 @@ Checks: "-*,\
   -cppcoreguidelines-pro-bounds-array-to-pointer-decay,\
   -cppcoreguidelines-pro-type-reinterpret-cast,\
   -cppcoreguidelines-pro-bounds-constant-array-index,\
+  -*-avoid-c-arrays,\
   -readability-else-after-return,\
   -readability-named-parameter,\
   -readability-use-anyofallof"
@@ -29,6 +30,9 @@ Checks: "-*,\
 # cppcoreguidelines-pro-bounds-constant-array-index
 #   ignore reason: infeasible to avoid without GSL
 
+# *-avoid-c-arrays
+#   ignore reason: often makes code significantly more verbose
+
 # readability-else-after-return
 #   ignore reason: personal preference of OLEGSHA (using 'else' helps highlight
 #   branches in code)