Loaders are observable. Modules refactoring

- Now it is possible to monitor loaders and tasks they perform
- Now it is NOT possible to add  dublicate tasks and modules
This commit is contained in:
Евгений Смирнов 2021-07-09 18:12:30 +03:00
parent f520d4b2c6
commit c7842935ba
4 changed files with 44 additions and 26 deletions

View File

@ -31,14 +31,13 @@ public class AudioSystem {
Thread shutdownHook = new Thread(AudioManager::closeAL, "AL Shutdown Hook"); Thread shutdownHook = new Thread(AudioManager::closeAL, "AL Shutdown Hook");
Runtime.getRuntime().addShutdownHook(shutdownHook); Runtime.getRuntime().addShutdownHook(shutdownHook);
Task t = new Task("AudioSystem:Initialize") { Task t = new Task("AudioSystem:Initialize", audioModule) {
@Override @Override
protected void perform() { protected void perform() {
loadAudioData(); loadAudioData();
LogManager.getLogger().info("Audio data is loaded"); LogManager.getLogger().info("Audio data is loaded");
} }
}; };
audioModule.addTask(t);
TaskManager.getInstance().registerModule(audioModule); TaskManager.getInstance().registerModule(audioModule);
} }

View File

@ -2,16 +2,13 @@ package ru.windcorp.progressia.common.modules;
import ru.windcorp.progressia.common.util.namespaces.Namespaced; import ru.windcorp.progressia.common.util.namespaces.Namespaced;
import java.util.ArrayList; import java.util.*;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
public class Module extends Namespaced { public class Module extends Namespaced {
private final List<Task> tasks = new ArrayList<>(); private final List<Task> tasks = new ArrayList<>();
private final Map<String, String> meta = new HashMap<>(); private final Map<String, String> meta = new HashMap<>();
private final boolean done = false; private final Map<String, String> unmodifiableMeta = Collections.unmodifiableMap(meta);
public Module(String id) { public Module(String id) {
@ -19,7 +16,7 @@ public class Module extends Namespaced {
} }
public Map<String, String> getMeta() { public Map<String, String> getMeta() {
return meta; return unmodifiableMeta;
} }
public List<Task> getTasks() { public List<Task> getTasks() {
@ -27,19 +24,8 @@ public class Module extends Namespaced {
} }
public void addTask(Task task) { public void addTask(Task task) {
task.setOwner(this);
tasks.add(task); tasks.add(task);
} }
/**
* @return false - not all tasks are done
*/
public boolean done() {
for (Task t : tasks) {
if (!t.isDone()) {
return false;
}
}
return true;
}
} }

View File

@ -1,5 +1,6 @@
package ru.windcorp.progressia.common.modules; package ru.windcorp.progressia.common.modules;
import ru.windcorp.progressia.common.util.crash.CrashReports;
import ru.windcorp.progressia.common.util.namespaces.Namespaced; import ru.windcorp.progressia.common.util.namespaces.Namespaced;
import java.util.ArrayList; import java.util.ArrayList;
@ -12,11 +13,17 @@ public abstract class Task
List<Task> requiredTasks = new ArrayList<>(); List<Task> requiredTasks = new ArrayList<>();
private boolean isDone = false; private boolean isDone = false;
private boolean isActive = false; private boolean isActive = false;
private Module owner;
protected Task(String id) { public Task(String id) {
super(id); super(id);
} }
public Task(String id, Module module) {
this(id);
module.addTask(this);
}
@Override @Override
public void run() { public void run() {
isActive = true; isActive = true;
@ -50,4 +57,19 @@ public abstract class Task
public void addRequiredTask(Task task) { public void addRequiredTask(Task task) {
requiredTasks.add(task); requiredTasks.add(task);
} }
public void setOwner(Module module) {
if(owner != null) {
CrashReports.crash(
new Exception("Owner is not null")
, "Could not set %s as owner of %s, because %s is already owner of it.",
module.getId(), this.getId(), this.getOwner().getId());
} else {
owner = module;
}
}
public Module getOwner() {
return owner;
}
} }

View File

@ -1,11 +1,9 @@
package ru.windcorp.progressia.common.modules; package ru.windcorp.progressia.common.modules;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import ru.windcorp.progressia.common.util.crash.CrashReports; import ru.windcorp.progressia.common.util.crash.CrashReports;
import java.util.ArrayList; import java.util.*;
import java.util.List;
import java.util.concurrent.ExecutorService; import java.util.concurrent.ExecutorService;
import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicBoolean;
import java.util.concurrent.atomic.AtomicInteger; import java.util.concurrent.atomic.AtomicInteger;
@ -14,17 +12,24 @@ import static java.util.concurrent.Executors.newFixedThreadPool;
public class TaskManager { public class TaskManager {
private static final TaskManager instance = new TaskManager(); private static final TaskManager instance = new TaskManager();
private final List<Task> tasks = new ArrayList<>();
private final List<Module> modules = new ArrayList<>(); private final Set<Task> tasks = new HashSet<>();
private final Set<Module> modules = new HashSet<>();
private final ExecutorService executorService; private final ExecutorService executorService;
private final AtomicBoolean loadingDone; private final AtomicBoolean loadingDone;
private final AtomicInteger activeThreadsCount; private final AtomicInteger activeThreadsCount;
private final Map<Thread, Task> loadersMonitorMap;
Map<Thread, Task> unmodifiableLoadersMonitorMap;
private TaskManager() { private TaskManager() {
loadingDone = new AtomicBoolean(false); loadingDone = new AtomicBoolean(false);
activeThreadsCount = new AtomicInteger(0); activeThreadsCount = new AtomicInteger(0);
executorService = newFixedThreadPool( executorService = newFixedThreadPool(
Runtime.getRuntime().availableProcessors(), Thread::new); Runtime.getRuntime().availableProcessors(), Thread::new);
loadersMonitorMap = new HashMap<>(Runtime.getRuntime().availableProcessors());
unmodifiableLoadersMonitorMap = Collections.unmodifiableMap(loadersMonitorMap);
} }
public static TaskManager getInstance() { public static TaskManager getInstance() {
@ -48,7 +53,9 @@ public class TaskManager {
Task t = getRunnableTask(); Task t = getRunnableTask();
if (t != null) { if (t != null) {
activeThreadsCount.incrementAndGet(); activeThreadsCount.incrementAndGet();
loadersMonitorMap.put(Thread.currentThread(), t);
t.run(); t.run();
loadersMonitorMap.put(Thread.currentThread(), null);
activeThreadsCount.decrementAndGet(); activeThreadsCount.decrementAndGet();
synchronized (this) { synchronized (this) {
notifyAll(); notifyAll();
@ -104,4 +111,8 @@ public class TaskManager {
} }
} }
public Map<Thread, Task> getLoadersMonitorMap() {
return unmodifiableLoadersMonitorMap;
}
} }